Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small problems with Caprover #140

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Small problems with Caprover #140

wants to merge 3 commits into from

Conversation

casparjones
Copy link

Since labels that are created in Caprover can no longer be deleted so easily, but only overwritten, I have implemented a few improvements:

  • Empty values are skipped, so you can also delete values again in Caprover
  • Check whether a "." exists in the key. For testing I had set the name of the job to "false", which led to a parsing error
  • To be able to deactivate jobs, I added an enabled to the job, which skips the job if false.

@funkyfuture
Copy link
Owner

okay, i don't know what a caprover is, so you need to provide information what this is and what actually the problem is when it meets deck_chores. i can't infer that from the provided solutions. also please revert any unrelated formatting changes / apply code normalization with black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casparjones @funkyfuture